diff options
| author | Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com> | 2013-06-26 23:56:43 +0900 |
|---|---|---|
| committer | Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com> | 2013-06-26 23:56:43 +0900 |
| commit | da7400ef5c62ee144fc14ba7ca4745349f0b0c72 (patch) | |
| tree | b0d023eecfcfcca2a88eb3466baf878bdff9f4c1 /src/SimpleRandomizer.cc | |
| parent | 47402c5f29cb806f73aae2ed18aa2dde21956700 (diff) | |
Return std::unique_ptr member as const ref
Returning raw pointer has a risk that it may be stolen by
std::shared_ptr in accident.
Diffstat (limited to 'src/SimpleRandomizer.cc')
| -rw-r--r-- | src/SimpleRandomizer.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/SimpleRandomizer.cc b/src/SimpleRandomizer.cc index dc558e3d..5d304243 100644 --- a/src/SimpleRandomizer.cc +++ b/src/SimpleRandomizer.cc @@ -45,12 +45,12 @@ namespace aria2 { std::unique_ptr<SimpleRandomizer> SimpleRandomizer::randomizer_; -SimpleRandomizer* SimpleRandomizer::getInstance() +const std::unique_ptr<SimpleRandomizer>& SimpleRandomizer::getInstance() { if(!randomizer_) { randomizer_.reset(new SimpleRandomizer()); } - return randomizer_.get(); + return randomizer_; } void SimpleRandomizer::init() |