From da7400ef5c62ee144fc14ba7ca4745349f0b0c72 Mon Sep 17 00:00:00 2001 From: Tatsuhiro Tsujikawa Date: Wed, 26 Jun 2013 23:56:43 +0900 Subject: Return std::unique_ptr member as const ref Returning raw pointer has a risk that it may be stolen by std::shared_ptr in accident. --- src/SimpleRandomizer.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/SimpleRandomizer.cc') diff --git a/src/SimpleRandomizer.cc b/src/SimpleRandomizer.cc index dc558e3d..5d304243 100644 --- a/src/SimpleRandomizer.cc +++ b/src/SimpleRandomizer.cc @@ -45,12 +45,12 @@ namespace aria2 { std::unique_ptr SimpleRandomizer::randomizer_; -SimpleRandomizer* SimpleRandomizer::getInstance() +const std::unique_ptr& SimpleRandomizer::getInstance() { if(!randomizer_) { randomizer_.reset(new SimpleRandomizer()); } - return randomizer_.get(); + return randomizer_; } void SimpleRandomizer::init() -- cgit