diff options
| author | Florian Eckert <fe@dev.tdt.de> | 2023-07-21 12:56:34 +0200 |
|---|---|---|
| committer | Florian Eckert <fe@dev.tdt.de> | 2023-07-24 09:41:51 +0200 |
| commit | 30911865b2791c1eb516559cfb414b17e2be5f64 (patch) | |
| tree | 23e39062505d7b0664a5b11b4b2bb694004dcd31 /net | |
| parent | 7513c483ddc0e3c3137869c8e692957436a08925 (diff) | |
modemmanager: do not set proto_notify_error on teardown
If on teardown the 'proto_notify_error' is set to 'MM_TEARDOWN_IN_PROGRESS',
then an error which is set on 'setup' is not visible in the ubus
network.interface.<iface> status output.
{
"up": false,
"pending": false,
"available": true,
"autostart": false,
"dynamic": false,
"proto": "modemmanager",
"data": {
},
"errors": [
{
"subsystem": "dualsim",
"code": "MM_TEARDOWN_IN_PROGRESS"
}
]
}
It alway shows the code 'MM_TEARDWON_IN_PROGRESS'!
By removing the line 'proto_notify_error "${interface}" MM_TEARDOWN_IN_PROGRESS'
in teardown, the last error is show in the proto stack from setup.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Diffstat (limited to 'net')
| -rw-r--r-- | net/modemmanager/Makefile | 2 | ||||
| -rwxr-xr-x | net/modemmanager/files/modemmanager.proto | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/net/modemmanager/Makefile b/net/modemmanager/Makefile index aa141ad73..df2e1e71b 100644 --- a/net/modemmanager/Makefile +++ b/net/modemmanager/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=modemmanager PKG_SOURCE_VERSION:=1.20.6 -PKG_RELEASE:=4 +PKG_RELEASE:=5 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL:=https://gitlab.freedesktop.org/mobile-broadband/ModemManager.git diff --git a/net/modemmanager/files/modemmanager.proto b/net/modemmanager/files/modemmanager.proto index 239148798..d2483207f 100755 --- a/net/modemmanager/files/modemmanager.proto +++ b/net/modemmanager/files/modemmanager.proto @@ -505,7 +505,6 @@ proto_modemmanager_teardown() { json_get_vars device lowpower iptype echo "stopping network" - proto_notify_error "${interface}" MM_TEARDOWN_IN_PROGRESS # load connected bearer information, just the first one should be ok modemstatus=$(mmcli --modem="${device}" --output-keyvalue) |