diff options
| author | Stijn Tintel <stijn@linux-ipv6.be> | 2017-03-07 13:41:01 +0100 |
|---|---|---|
| committer | Stijn Tintel <stijn@linux-ipv6.be> | 2017-03-08 21:15:20 +0100 |
| commit | f82287cf5c1b2acd46feb52fb9b3cb3697e7086b (patch) | |
| tree | b51dc0c6f1eeb94b0cbd039b352d79c8a82d2736 /CONTRIBUTING.md | |
| parent | 694e5a677cdacf0966d759deb75f03c0c927bd2a (diff) | |
treewide: use name in define and eval lines
For consistency, use full name instead of $(PKG_NAME) in define and eval
lines for all packages.
I've seen reviews that asked to do this before, and I am asking the same
during reviews now. To avoid this in the future, fix this treewide so
when people use existing packages as example, we will not have to
request this change anymore.
This makes all packages consistent with both LEDE and OpenWrt base
repositories.
Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 29ba5dbaa..4cfaef151 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,6 +22,7 @@ All packages you commit or submit by pull-request should follow these simple gui * An optional PKG_LICENSE_FILES tag including the filenames of the license-files in the source-package. (E.g.: PKG_LICENSE_FILES:=COPYING) * PKG_RELEASE should be initially set to 1 or reset to 1 if the software version is changed. You should increment it if the package itself has changed. For example, modifying a support script, changing configure options like --disable* or --enable* switches, or if you changed something in the package which causes the resulting binaries to be different. Changes like correcting md5sums, changing mirror URLs, adding a maintainer field or updating a comment or copyright year in a Makefile do not require a change to PKG_RELEASE. +* Avoid reuse of PKG_NAME in call, define and eval lines to improve readability. #### Commits in your pull-requests should: |