summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge remote-tracking branch 'upstream/master' into utp-supportHEADutp-supportroot2024-01-199-10/+10
|\
| * Fix various typosluzpaz2024-01-149-10/+10
| | | | | | | | Found via `codespell -q 3 -S "./deps,./ChangeLog.old,./LICENSE.OpenSSL,./doc/manual-src/pt,./doc/sphinx_themes/sphinx_rtd_theme/locale" -L ans,anull,clen,dependant,filetest,fo,hel,nd,orign,padd,parm,servent,tennant,worl,windows`
* | bugfixHEADHanjie Wu2023-12-192-20/+29
| |
* | fix notificationHanjie Wu2023-12-183-6/+26
| |
* | fix notification issueHanjie Wu2023-12-185-19/+42
| |
* | fix readDataFromHanjie Wu2023-12-181-1/+1
| |
* | add uTP field in RPCHanjie Wu2023-12-161-0/+2
| |
* | add uTP accept callbackHanjie Wu2023-12-162-15/+44
| |
* | bugfixHanjie Wu2023-12-163-6/+7
| |
* | fixHanjie Wu2023-12-161-6/+6
| |
* | fix c++11 issueHanjie Wu2023-12-162-2/+2
| |
* | add retry different protocolsHanjie Wu2023-12-1613-53/+135
| |
* | more C++11 compatibility issuesHanjie Wu2023-12-162-5/+8
| |
* | fix C++11 compatibility issuesHanjie Wu2023-12-162-4/+8
| |
* | add uTP support for outbound connectionsHanjie Wu2023-12-1645-81/+7361
|/
* Fix spellinga13460542023-11-0510-10/+10
|
* Merge pull request #1982 from h3xx/update-docsTatsuhiro Tsujikawa2023-11-051-1/+1
|\ | | | | Various documenation fixes and rewords
| * Fix misspelled wordDan Church2022-09-271-1/+1
| |
* | Fix build error without bittorrentTatsuhiro Tsujikawa2023-11-031-0/+1
| | | | | | | | Amends #2127
* | Cap infoHashLength in .aria2 fileTatsuhiro Tsujikawa2023-11-021-6/+7
| | | | | | | | Cap infoHashLength in .aria2 file, and save an extra allocation.
* | clang-formatTatsuhiro Tsujikawa2023-11-029-56/+57
| |
* | Logger: Fix format string overflow in writeHeader()Alexander Egorenkov2023-10-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This problem occurred on a 32-bit ARM OpenWRT router running Linux 6.1. The method writeHeader() assumes that the size of struct timeval is 8 bytes which is not true on this machine, it is 16 bytes large. Therefore, first cast tv.tv_usec to the unsigned long type. ========= GDB trace ========= (gdb) c Continuing. Program received signal SIGSEGV, Segmentation fault. 0xb6f4f9b4 in memchr (src=src@entry=0x3b6a, c=c@entry=0x0, n=n@entry=0x7fffffff) at src/string/memchr.c:16 16 for (; ((uintptr_t)s & ALIGN) && n && *s != c; s++, n--); 0xb6f4f98c <memchr+12>: 00 00 52 e3 cmp r2, #0 0xb6f4f990 <memchr+16>: 00 30 a0 e1 mov r3, r0 0xb6f4f994 <memchr+20>: 05 00 00 1a bne 0xb6f4f9b0 <memchr+48> 0xb6f4f998 <memchr+24>: 32 00 00 ea b 0xb6f4fa68 <memchr+232> 0xb6f4f99c <memchr+28>: 03 00 13 e3 tst r3, #3 0xb6f4f9a0 <memchr+32>: 01 20 42 e2 sub r2, r2, #1 0xb6f4f9a4 <memchr+36>: 36 00 00 0a beq 0xb6f4fa84 <memchr+260> 0xb6f4f9a8 <memchr+40>: 00 00 52 e3 cmp r2, #0 0xb6f4f9ac <memchr+44>: 2d 00 00 0a beq 0xb6f4fa68 <memchr+232> 0xb6f4f9b0 <memchr+48>: 03 00 a0 e1 mov r0, r3 => 0xb6f4f9b4 <memchr+52>: 01 c0 d3 e4 ldrb r12, [r3], #1 0xb6f4f9b8 <memchr+56>: 01 00 5c e1 cmp r12, r1 0xb6f4f9bc <memchr+60>: f6 ff ff 1a bne 0xb6f4f99c <memchr+28> (gdb) bt #0 0xb6f4f9b4 in memchr (src=src@entry=0x3b6a, c=c@entry=0x0, n=n@entry=0x7fffffff) at src/string/memchr.c:16 #1 0xb6f512b4 in strnlen (s=s@entry=0x3b6a <error: Cannot access memory at address 0x3b6a>, n=n@entry=0x7fffffff) at src/string/strnlen.c:5 #2 0xb6f19eb4 in printf_core (f=f@entry=0xb67d35b0, fmt=fmt@entry=0x101856 "%s.%06ld [%s] [%s:%d] ", ap=ap@entry=0xbe8f5a1c, nl_arg=nl_arg@entry=0xbe8f5a48, nl_type=<optimized out>, nl_type@entry=0xbe8f5a20) at src/stdio/vfprintf.c:599 #3 0xb6f4b86c in vfprintf (f=0xb67d35b0, fmt=0x101856 "%s.%06ld [%s] [%s:%d] ", ap=...) at src/stdio/vfprintf.c:688 #4 0x0001d92c in aria2::OutputFile::printf (this=<optimized out>, format=0x101856 "%s.%06ld [%s] [%s:%d] ") at OutputFile.h:58 #5 0x00027910 in aria2::(anonymous namespace)::writeHeader<aria2::OutputFile> (lineNum=0xba, sourceFile=0x10d842 "HttpServer.cc", level=aria2::Logger::A2_INFO, fp=...) at Logger.cc:136 #6 aria2::Logger::writeLog (this=0xb67cf78c, level=aria2::Logger::A2_INFO, sourceFile=0x10d842 "HttpServer.cc", lineNum=0xba, msg=0xb6766280 "HTTP Server received request\nPOST /jsonrpc HTTP/1.1\r\nHost: 192.168 .1.1:6800\r\nUser-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0\r\nAccept: application/json, text/plain, *"..., msg@entry=0x10d842 "HttpServer.cc", trace=trace@entry=0x124806 "") a t Logger.cc:196 #7 0x00028bf0 in aria2::Logger::log (this=<optimized out>, level=<optimized out>, sourceFile=<optimized out>, lineNum=<optimized out>, msg=0xb6766280 "HTTP Server received request\nPOST /jsonrpc HTTP/1.1\r\nHost : 192.168.1.1:6800\r\nUser-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0\r\nAccept: application/json, text/plain, *"...) at Logger.cc:213 #8 0x00081708 in aria2::HttpServer::receiveRequest (this=0xb6774430) at /home/egorenar/Repositories/openwrt-rel/staging_dir/toolchain-arm_cortex-a15+neon-vfpv4_gcc-12.3.0_musl_eabi/arm-openwrt-linux-muslgnueabi/ include/c++/12.3.0/bits/basic_string.h:233 #9 aria2::HttpServerCommand::execute (this=0xb6772620) at HttpServerCommand.cc:194 #10 0x00076de4 in aria2::(anonymous namespace)::executeCommand (commands=..., statusFilter=aria2::Command::STATUS_ALL) at DownloadEngine.cc:139 #11 0x0001913c in aria2::DownloadEngine::run (oneshot=0x0, this=0xb67967e0) at DownloadEngine.cc:180 #12 aria2::MultiUrlRequestInfo::execute (this=0xb67dee6c) at MultiUrlRequestInfo.cc:361 #13 aria2::main (argv=<optimized out>, argc=<optimized out>) at main.cc:78 #14 main (argc=<optimized out>, argv=<optimized out>) at main.cc:91 (gdb) p tv $13 = { tv_sec = 0x652134fd, tv_usec = 0x3b6a } (gdb) call sizeof(tv) $14 = 0x10 (gdb) call sizeof(tv.tv_usec) $15 = 0x8 (gdb) call sizeof(long) $16 = 0x4 (gdb) call sizeof(unsigned long) $17 = 0x4 (gdb) call sizeof(time_t) $18 = 0x8 Signed-off-by: Alexander Egorenkov <egorenar-dev@posteo.net>
* | Merge pull request #2108 from aria2/memcpyTatsuhiro Tsujikawa2023-09-183-19/+21
|\ \ | | | | | | Avoid non-nil argument errors
| * | Avoid non-nil argument errorsTatsuhiro Tsujikawa2023-09-183-19/+21
| | | | | | | | | | | | | | | Use std::copy_n and std::fill_n to avoid a non-nil argument error with memcpy/memset.
* | | Do not close stdout and stderrTatsuhiro Tsujikawa2023-09-181-1/+3
|/ /
* | Bail out if pieceLength is 0Tatsuhiro Tsujikawa2023-09-181-0/+4
| |
* | Call the member function of IOFileTatsuhiro Tsujikawa2023-09-181-2/+2
| |
* | Move instead of copyTatsuhiro Tsujikawa2023-09-181-2/+2
| |
* | Fix overflowTatsuhiro Tsujikawa2023-09-161-1/+1
| |
* | Fix test errors with ubsanTatsuhiro Tsujikawa2023-09-162-7/+13
| |
* | Remove deprecated std::unary_function and std::binary_functionTatsuhiro Tsujikawa2023-09-164-6/+4
| |
* | Prefer random number generator from crypto librariesTatsuhiro Tsujikawa2023-09-161-2/+22
| |
* | Merge pull request #1893 from kelson42/increase-bytearraydiskwriter-maxTatsuhiro Tsujikawa2023-09-151-1/+1
|\ \ | |/ |/| Increase ByteArrayDiskWriter maximum size
| * Increase ByteArrayDiskWriter maximum sizeEmmanuel Engelhart2022-03-051-1/+1
| |
* | Merge pull request #1969 from himikof/patch-1Tatsuhiro Tsujikawa2022-08-251-4/+4
|\ \ | | | | | | Fix Metalink4 parsing with foreign namespaces
| * | Fix Metalink4 parsing with foreign namespacesNikita Ofitserov2022-08-231-4/+4
| | | | | | | | | | | | Rename local checkNsUri helper function to make boolean conditions easily readable, as the issue was not apparent with the old helper function name.
* | | Fix undefined behavior/crash in GZipEncoderNikita Ofitserov2022-08-241-1/+1
|/ / | | | | | | When the output buffer is full, outbuf[produced] references past the buffer end, leading to UB and a possible assertion failure. Fixes #1968, #1964
* | Add missing <array>Hernan Martinez2022-06-231-1/+1
| |
* | Better entropy for getRandomBytesTatsuhiro Tsujikawa2022-04-091-10/+38
| |
* | Allow empty dist name in bencode which is needed for hybrid torrentTatsuhiro Tsujikawa2022-04-086-5/+31
| |
* | add no-want-digest-header optioncarsonzhu2022-04-035-0/+19
| |
* | Merge pull request #1877 from h3xx/fix-doc-typoTatsuhiro Tsujikawa2022-04-031-1/+1
|\ \ | | | | | | Fix typo in documentation, --help text
| * | Fix typoDan Church2022-01-191-1/+1
| |/
* | Merge pull request #1824 from richardnias/fix-accept-encoding-docsTatsuhiro Tsujikawa2022-04-031-3/+3
|\ \ | |/ |/| Fix header in --http-accept-gzip documentation
| * Fix header in --http-accept-gzip documentationRichard Nias2021-09-171-3/+3
| |
* | clang-format-12Tatsuhiro Tsujikawa2021-10-306-14/+14
| |
* | Cosmetic changeTatsuhiro Tsujikawa2021-10-301-1/+0
| |
* | SimplifyTatsuhiro Tsujikawa2021-10-301-3/+1
| |
* | Build with OpenSSL 3.0.0Tatsuhiro Tsujikawa2021-10-296-5/+119
|/
* Replace the deprecated std::ptr_fun with std::functionTatsuhiro Tsujikawa2021-08-121-4/+6
|