diff options
| author | Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com> | 2013-06-26 23:56:43 +0900 |
|---|---|---|
| committer | Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com> | 2013-06-26 23:56:43 +0900 |
| commit | da7400ef5c62ee144fc14ba7ca4745349f0b0c72 (patch) | |
| tree | b0d023eecfcfcca2a88eb3466baf878bdff9f4c1 /src/UTMetadataPostDownloadHandler.cc | |
| parent | 47402c5f29cb806f73aae2ed18aa2dde21956700 (diff) | |
Return std::unique_ptr member as const ref
Returning raw pointer has a risk that it may be stolen by
std::shared_ptr in accident.
Diffstat (limited to 'src/UTMetadataPostDownloadHandler.cc')
| -rw-r--r-- | src/UTMetadataPostDownloadHandler.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/UTMetadataPostDownloadHandler.cc b/src/UTMetadataPostDownloadHandler.cc index 82084243..58e3002a 100644 --- a/src/UTMetadataPostDownloadHandler.cc +++ b/src/UTMetadataPostDownloadHandler.cc @@ -59,8 +59,7 @@ bool UTMetadataPostDownloadHandler::Criteria::match const std::shared_ptr<DownloadContext>& dctx = requestGroup->getDownloadContext(); if(dctx->hasAttribute(CTX_ATTR_BT)) { - auto attrs = bittorrent::getTorrentAttrs(dctx); - if(attrs->metadata.empty()) { + if(bittorrent::getTorrentAttrs(dctx)->metadata.empty()) { return true; } } |