Fix infinite loop when size of downloadResults_ exceeds maxDownloadResult_

1 files changed, 3 insertions, 0 deletions

diff --git a/src/RequestGroupMan.cc b/src/RequestGroupMan.cc
index e5cdc095..d232c5e0 100644
--- a/src/RequestGroupMan.cc
+++ b/src/RequestGroupMan.cc
@@ -883,11 +883,14 @@ void RequestGroupMan::addDownloadResult(const SharedHandle<DownloadResult>& dr)
   assert(rv);
   while(downloadResults_.size() > maxDownloadResult_){
     DownloadResultList::SeqType::iterator i = downloadResults_.begin();
+    // Save last encountered error code so that we can report it
+    // later.
     const SharedHandle<DownloadResult>& dr = (*i).second;
     if(dr->belongsTo == 0 && dr->result != error_code::FINISHED) {
       removedLastErrorResult_ = dr->result;
       ++removedErrorResult_;
     }
+    downloadResults_.pop_front();
   }
 }