diff options
| author | Toke Høiland-Jørgensen <toke@toke.dk> | 2015-06-17 13:03:03 +0200 |
|---|---|---|
| committer | Toke Høiland-Jørgensen <toke@toke.dk> | 2015-06-17 13:04:54 +0200 |
| commit | 725b31909bed2066575c05215238b634d62ab6e7 (patch) | |
| tree | 24fdbf99e2425c130f00e9d51f1e48316d3de4bd | |
| parent | aad08fea8787a24b31cd18c0afb3600587085f64 (diff) | |
[sqm-scripts/luci-app-sqm] Document how to disable shaping on a per direction basis
sqm-scripts for a long time interprets a "Down- or Upload speed" of zero as
an indication that the shaper should be disabled. Note that really shaping
an individual direction down o zero will make the link effectively dead
for tcp (think reverse ACK traffic). Son instead of allowing the user to
configure something broken, 0 was "over-loaded" to denote no shaping
since several years, but that information has not been documented visibly
to the users. This commit aims at fixing that oversight.
Signed-off-by: Sebastian Moeller <moeller0@gmx.de>
| -rw-r--r-- | net/luci-app-sqm/Makefile | 2 | ||||
| -rw-r--r-- | net/luci-app-sqm/files/sqm-cbi.lua | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/net/luci-app-sqm/Makefile b/net/luci-app-sqm/Makefile index f0bb2a0ac..c4fbc1283 100644 --- a/net/luci-app-sqm/Makefile +++ b/net/luci-app-sqm/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=luci-app-sqm PKG_VERSION:=3 -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_LICENSE:=GPLv2 LUCI_DIR:=/usr/lib/lua/luci diff --git a/net/luci-app-sqm/files/sqm-cbi.lua b/net/luci-app-sqm/files/sqm-cbi.lua index 837902597..49ab13057 100644 --- a/net/luci-app-sqm/files/sqm-cbi.lua +++ b/net/luci-app-sqm/files/sqm-cbi.lua @@ -52,11 +52,11 @@ end n.rmempty = false -dl = s:taboption("tab_basic", Value, "download", translate("Download speed (kbit/s) (ingress):")) +dl = s:taboption("tab_basic", Value, "download", translate("Download speed (kbit/s) (ingress) set to 0 to selectively disable ingress shaping:")) dl.datatype = "and(uinteger,min(0))" dl.rmempty = false -ul = s:taboption("tab_basic", Value, "upload", translate("Upload speed (kbit/s) (egress):")) +ul = s:taboption("tab_basic", Value, "upload", translate("Upload speed (kbit/s) (egress) set to 0 to selectively disable egress shaping:")) ul.datatype = "and(uinteger,min(0))" ul.rmempty = false |