From efbfe4c006cfb6e0bf3ee4ed57d0657c0cd85c19 Mon Sep 17 00:00:00 2001 From: Tatsuhiro Tsujikawa Date: Mon, 6 Sep 2010 14:29:36 +0000 Subject: 2010-09-06 Tatsuhiro Tsujikawa Data from remote server in HTTP/FTP download are now written to the disk(or memory) through StreamFilter. Decoding chunked and gziped streams are done cascading StreamFilter. Removed inefficient 1byte read code. * src/ChunkedDecodingStreamFilter.cc * src/ChunkedDecodingStreamFilter.h * src/DownloadCommand.cc * src/DownloadCommand.h * src/GZipDecodingStreamFilter.cc * src/GZipDecodingStreamFilter.h * src/HttpConnection.cc * src/HttpDownloadCommand.cc * src/HttpResponse.cc * src/HttpResponse.h * src/HttpResponseCommand.cc * src/HttpResponseCommand.h * src/HttpSkipResponseCommand.cc * src/HttpSkipResponseCommand.h * src/Makefile.am * src/NullSinkStreamFilter.cc * src/NullSinkStreamFilter.h * src/RequestGroup.cc * src/SinkStreamFilter.cc * src/SinkStreamFilter.h * src/StreamFilter.cc * src/StreamFilter.h * test/ChunkedDecodingStreamFilterTest.cc * test/GZipDecodingStreamFilterTest.cc * test/HttpResponseTest.cc * test/Makefile.am * test/MockSegment.h --- test/ChunkedDecodingStreamFilterTest.cc | 240 ++++++++++++++++++++++++++++++++ 1 file changed, 240 insertions(+) create mode 100644 test/ChunkedDecodingStreamFilterTest.cc (limited to 'test/ChunkedDecodingStreamFilterTest.cc') diff --git a/test/ChunkedDecodingStreamFilterTest.cc b/test/ChunkedDecodingStreamFilterTest.cc new file mode 100644 index 00000000..8dea7bd1 --- /dev/null +++ b/test/ChunkedDecodingStreamFilterTest.cc @@ -0,0 +1,240 @@ +#include "ChunkedDecodingStreamFilter.h" + +#include +#include +#include + +#include "DlAbortEx.h" +#include "Segment.h" +#include "ByteArrayDiskWriter.h" +#include "SinkStreamFilter.h" +#include "MockSegment.h" + +namespace aria2 { + +class ChunkedDecodingStreamFilterTest:public CppUnit::TestFixture { + + CPPUNIT_TEST_SUITE(ChunkedDecodingStreamFilterTest); + CPPUNIT_TEST(testTransform); + CPPUNIT_TEST(testTransform_withoutTrailer); + CPPUNIT_TEST(testTransform_with2Trailers); + CPPUNIT_TEST(testTransform_largeChunkSize); + CPPUNIT_TEST(testTransform_tooLargeChunkSize); + CPPUNIT_TEST(testTransform_chunkSizeMismatch); + CPPUNIT_TEST(testGetName); + CPPUNIT_TEST_SUITE_END(); + + SharedHandle filter_; + SharedHandle sinkFilter_; + SharedHandle writer_; + SharedHandle segment_; + + void clearWriter() + { + writer_->setString(""); + } +public: + void setUp() + { + writer_.reset(new ByteArrayDiskWriter()); + sinkFilter_.reset(new SinkStreamFilter()); + filter_.reset(new ChunkedDecodingStreamFilter(sinkFilter_)); + sinkFilter_->init(); + filter_->init(); + segment_.reset(new MockSegment()); + } + + void testTransform(); + void testTransform_withoutTrailer(); + void testTransform_with2Trailers(); + void testTransform_largeChunkSize(); + void testTransform_tooLargeChunkSize(); + void testTransform_chunkSizeMismatch(); + void testGetName(); +}; + + +CPPUNIT_TEST_SUITE_REGISTRATION( ChunkedDecodingStreamFilterTest ); + +void ChunkedDecodingStreamFilterTest::testTransform() +{ + try { + { + std::basic_string msg = + reinterpret_cast("a\r\n1234567890\r\n"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)10, r); + CPPUNIT_ASSERT_EQUAL(std::string("1234567890"), writer_->getString()); + } + clearWriter(); + // Feed extension; see it is ignored. + { + std::basic_string msg = + reinterpret_cast + ("3;extensionIgnored\r\n123\r\n"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)3, r); + CPPUNIT_ASSERT_EQUAL(std::string("123"), writer_->getString()); + } + clearWriter(); + // Feed 2extensions; see it is ignored. + { + std::basic_string msg = + reinterpret_cast + ("3;extension1;extension2;\r\n123\r\n"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)3, r); + CPPUNIT_ASSERT_EQUAL(std::string("123"), writer_->getString()); + } + clearWriter(); + // Not all chunk size is available + { + std::basic_string msg = + reinterpret_cast("1"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)0, r); + } + clearWriter(); + { + std::basic_string msg = + reinterpret_cast("0\r\n1234567890123456\r\n"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)16, r); + CPPUNIT_ASSERT_EQUAL(std::string("1234567890123456"), + writer_->getString()); + } + clearWriter(); + // Not all chunk data is available + { + std::basic_string msg = + reinterpret_cast("10\r\n1234567890"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)10, r); + CPPUNIT_ASSERT_EQUAL(std::string("1234567890"), writer_->getString()); + } + clearWriter(); + { + std::basic_string msg = + reinterpret_cast("123456\r\n"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)6, r); + CPPUNIT_ASSERT_EQUAL(std::string("123456"), writer_->getString()); + } + clearWriter(); + // no trailing CR LF. + { + std::basic_string msg = + reinterpret_cast("10\r\n1234567890123456"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)16, r); + CPPUNIT_ASSERT_EQUAL(std::string("1234567890123456"), + writer_->getString()); + } + clearWriter(); + // feed only CR + { + std::basic_string msg = + reinterpret_cast("\r"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)0, r); + } + // feed next LF + { + std::basic_string msg = + reinterpret_cast("\n"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)0, r); + CPPUNIT_ASSERT_EQUAL(std::string(""), writer_->getString()); + } + // feed 0 CR LF. + { + std::basic_string msg = + reinterpret_cast("0\r\n"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)0, r); + } + // feed trailer + { + std::basic_string msg = + reinterpret_cast("trailer\r\n"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)0, r); + } + // feed final CRLF + { + std::basic_string msg = + reinterpret_cast("\r\n"); + ssize_t r = filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_ASSERT_EQUAL((ssize_t)0, r); + } + // input is over + CPPUNIT_ASSERT(filter_->finished()); + } catch(DlAbortEx& e) { + CPPUNIT_FAIL(e.stackTrace()); + } +} + +void ChunkedDecodingStreamFilterTest::testTransform_withoutTrailer() +{ + CPPUNIT_ASSERT_EQUAL + ((ssize_t)0, + filter_->transform + (writer_, segment_, + reinterpret_cast("0\r\n\r\n"), 5)); + CPPUNIT_ASSERT(filter_->finished()); +} + +void ChunkedDecodingStreamFilterTest::testTransform_with2Trailers() +{ + CPPUNIT_ASSERT_EQUAL + ((ssize_t)0, + filter_->transform + (writer_, segment_, + reinterpret_cast("0\r\nt1\r\nt2\r\n\r\n"), 13)); + CPPUNIT_ASSERT(filter_->finished()); +} + +void ChunkedDecodingStreamFilterTest::testTransform_largeChunkSize() +{ + // chunkSize should be under 2^64-1 + { + std::basic_string msg = + reinterpret_cast("ffffffffffffffff\r\n"); + filter_->transform(writer_, segment_, msg.data(), msg.size()); + } +} + +void ChunkedDecodingStreamFilterTest::testTransform_tooLargeChunkSize() +{ + // chunkSize 2^64 causes error + { + std::basic_string msg = + reinterpret_cast("10000000000000000\r\n"); + try { + filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_FAIL("exception must be thrown."); + } catch(DlAbortEx& e) { + // success + } + } +} + +void ChunkedDecodingStreamFilterTest::testTransform_chunkSizeMismatch() +{ + std::basic_string msg = + reinterpret_cast("3\r\n1234\r\n"); + try { + filter_->transform(writer_, segment_, msg.data(), msg.size()); + CPPUNIT_FAIL("exception must be thrown."); + } catch(DlAbortEx& e) { + // success + } +} + +void ChunkedDecodingStreamFilterTest::testGetName() +{ + CPPUNIT_ASSERT_EQUAL + (std::string("ChunkedDecodingStreamFilter"), filter_->getName()); +} + +} // namespace aria2 -- cgit