From da7400ef5c62ee144fc14ba7ca4745349f0b0c72 Mon Sep 17 00:00:00 2001 From: Tatsuhiro Tsujikawa Date: Wed, 26 Jun 2013 23:56:43 +0900 Subject: Return std::unique_ptr member as const ref Returning raw pointer has a risk that it may be stolen by std::shared_ptr in accident. --- src/HttpRequestCommand.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/HttpRequestCommand.cc') diff --git a/src/HttpRequestCommand.cc b/src/HttpRequestCommand.cc index 678bec18..34b708a1 100644 --- a/src/HttpRequestCommand.cc +++ b/src/HttpRequestCommand.cc @@ -98,8 +98,8 @@ createHttpRequest(const std::shared_ptr& req, httpRequest->setFileEntry(fileEntry); httpRequest->setSegment(segment); httpRequest->addHeader(option->get(PREF_HEADER)); - httpRequest->setCookieStorage(e->getCookieStorage()); - httpRequest->setAuthConfigFactory(e->getAuthConfigFactory()); + httpRequest->setCookieStorage(e->getCookieStorage().get()); + httpRequest->setAuthConfigFactory(e->getAuthConfigFactory().get()); httpRequest->setOption(option.get()); httpRequest->setProxyRequest(proxyRequest); httpRequest->setAcceptMetalink(rg->getDownloadContext()-> -- cgit