summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | ci: Bump gcc and clangTatsuhiro Tsujikawa2023-11-021-6/+6
|/ /
* | Merge pull request #2117 from ↵Tatsuhiro Tsujikawa2023-10-091-2/+2
|\ \ | | | | | | | | | | | | egorenar/fix-formatr-string-overflow-in-logger-writeheader Logger: Fix format string overflow in writeHeader()
| * | Logger: Fix format string overflow in writeHeader()Alexander Egorenkov2023-10-071-2/+2
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This problem occurred on a 32-bit ARM OpenWRT router running Linux 6.1. The method writeHeader() assumes that the size of struct timeval is 8 bytes which is not true on this machine, it is 16 bytes large. Therefore, first cast tv.tv_usec to the unsigned long type. ========= GDB trace ========= (gdb) c Continuing. Program received signal SIGSEGV, Segmentation fault. 0xb6f4f9b4 in memchr (src=src@entry=0x3b6a, c=c@entry=0x0, n=n@entry=0x7fffffff) at src/string/memchr.c:16 16 for (; ((uintptr_t)s & ALIGN) && n && *s != c; s++, n--); 0xb6f4f98c <memchr+12>: 00 00 52 e3 cmp r2, #0 0xb6f4f990 <memchr+16>: 00 30 a0 e1 mov r3, r0 0xb6f4f994 <memchr+20>: 05 00 00 1a bne 0xb6f4f9b0 <memchr+48> 0xb6f4f998 <memchr+24>: 32 00 00 ea b 0xb6f4fa68 <memchr+232> 0xb6f4f99c <memchr+28>: 03 00 13 e3 tst r3, #3 0xb6f4f9a0 <memchr+32>: 01 20 42 e2 sub r2, r2, #1 0xb6f4f9a4 <memchr+36>: 36 00 00 0a beq 0xb6f4fa84 <memchr+260> 0xb6f4f9a8 <memchr+40>: 00 00 52 e3 cmp r2, #0 0xb6f4f9ac <memchr+44>: 2d 00 00 0a beq 0xb6f4fa68 <memchr+232> 0xb6f4f9b0 <memchr+48>: 03 00 a0 e1 mov r0, r3 => 0xb6f4f9b4 <memchr+52>: 01 c0 d3 e4 ldrb r12, [r3], #1 0xb6f4f9b8 <memchr+56>: 01 00 5c e1 cmp r12, r1 0xb6f4f9bc <memchr+60>: f6 ff ff 1a bne 0xb6f4f99c <memchr+28> (gdb) bt #0 0xb6f4f9b4 in memchr (src=src@entry=0x3b6a, c=c@entry=0x0, n=n@entry=0x7fffffff) at src/string/memchr.c:16 #1 0xb6f512b4 in strnlen (s=s@entry=0x3b6a <error: Cannot access memory at address 0x3b6a>, n=n@entry=0x7fffffff) at src/string/strnlen.c:5 #2 0xb6f19eb4 in printf_core (f=f@entry=0xb67d35b0, fmt=fmt@entry=0x101856 "%s.%06ld [%s] [%s:%d] ", ap=ap@entry=0xbe8f5a1c, nl_arg=nl_arg@entry=0xbe8f5a48, nl_type=<optimized out>, nl_type@entry=0xbe8f5a20) at src/stdio/vfprintf.c:599 #3 0xb6f4b86c in vfprintf (f=0xb67d35b0, fmt=0x101856 "%s.%06ld [%s] [%s:%d] ", ap=...) at src/stdio/vfprintf.c:688 #4 0x0001d92c in aria2::OutputFile::printf (this=<optimized out>, format=0x101856 "%s.%06ld [%s] [%s:%d] ") at OutputFile.h:58 #5 0x00027910 in aria2::(anonymous namespace)::writeHeader<aria2::OutputFile> (lineNum=0xba, sourceFile=0x10d842 "HttpServer.cc", level=aria2::Logger::A2_INFO, fp=...) at Logger.cc:136 #6 aria2::Logger::writeLog (this=0xb67cf78c, level=aria2::Logger::A2_INFO, sourceFile=0x10d842 "HttpServer.cc", lineNum=0xba, msg=0xb6766280 "HTTP Server received request\nPOST /jsonrpc HTTP/1.1\r\nHost: 192.168 .1.1:6800\r\nUser-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0\r\nAccept: application/json, text/plain, *"..., msg@entry=0x10d842 "HttpServer.cc", trace=trace@entry=0x124806 "") a t Logger.cc:196 #7 0x00028bf0 in aria2::Logger::log (this=<optimized out>, level=<optimized out>, sourceFile=<optimized out>, lineNum=<optimized out>, msg=0xb6766280 "HTTP Server received request\nPOST /jsonrpc HTTP/1.1\r\nHost : 192.168.1.1:6800\r\nUser-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0\r\nAccept: application/json, text/plain, *"...) at Logger.cc:213 #8 0x00081708 in aria2::HttpServer::receiveRequest (this=0xb6774430) at /home/egorenar/Repositories/openwrt-rel/staging_dir/toolchain-arm_cortex-a15+neon-vfpv4_gcc-12.3.0_musl_eabi/arm-openwrt-linux-muslgnueabi/ include/c++/12.3.0/bits/basic_string.h:233 #9 aria2::HttpServerCommand::execute (this=0xb6772620) at HttpServerCommand.cc:194 #10 0x00076de4 in aria2::(anonymous namespace)::executeCommand (commands=..., statusFilter=aria2::Command::STATUS_ALL) at DownloadEngine.cc:139 #11 0x0001913c in aria2::DownloadEngine::run (oneshot=0x0, this=0xb67967e0) at DownloadEngine.cc:180 #12 aria2::MultiUrlRequestInfo::execute (this=0xb67dee6c) at MultiUrlRequestInfo.cc:361 #13 aria2::main (argv=<optimized out>, argc=<optimized out>) at main.cc:78 #14 main (argc=<optimized out>, argv=<optimized out>) at main.cc:91 (gdb) p tv $13 = { tv_sec = 0x652134fd, tv_usec = 0x3b6a } (gdb) call sizeof(tv) $14 = 0x10 (gdb) call sizeof(tv.tv_usec) $15 = 0x8 (gdb) call sizeof(long) $16 = 0x4 (gdb) call sizeof(unsigned long) $17 = 0x4 (gdb) call sizeof(time_t) $18 = 0x8 Signed-off-by: Alexander Egorenkov <egorenar-dev@posteo.net>
* | Merge pull request #2108 from aria2/memcpyTatsuhiro Tsujikawa2023-09-183-19/+21
|\ \ | | | | | | Avoid non-nil argument errors
| * | Avoid non-nil argument errorsTatsuhiro Tsujikawa2023-09-183-19/+21
| | | | | | | | | | | | | | | Use std::copy_n and std::fill_n to avoid a non-nil argument error with memcpy/memset.
* | | Merge pull request #2107 from aria2/dont-close-stderr-stdoutTatsuhiro Tsujikawa2023-09-181-1/+3
|\ \ \ | |/ / |/| | Do not close stdout and stderr
| * | Do not close stdout and stderrTatsuhiro Tsujikawa2023-09-181-1/+3
|/ /
* | Merge pull request #2106 from aria2/static-check-fixTatsuhiro Tsujikawa2023-09-183-4/+8
|\ \ | | | | | | Static check fix
| * | Bail out if pieceLength is 0Tatsuhiro Tsujikawa2023-09-181-0/+4
| | |
| * | Call the member function of IOFileTatsuhiro Tsujikawa2023-09-181-2/+2
| | |
| * | Move instead of copyTatsuhiro Tsujikawa2023-09-181-2/+2
|/ /
* | Merge pull request #2105 from aria2/update-sphinx_rtd_themeTatsuhiro Tsujikawa2023-09-1848-265/+837
|\ \ | | | | | | Update sphinx_rtd_theme
| * | Update sphinx_rtd_themeTatsuhiro Tsujikawa2023-09-1748-265/+837
| | |
* | | Merge pull request #2104 from aria2/docker-mingw-update-cpTatsuhiro Tsujikawa2023-09-181-3/+1
|\ \ \ | | | | | | | | Dockerfile.mingw: Update how to get aria2c.exe from a container
| * | | Dockerfile.mingw: Update how to get aria2c.exe from a containerTatsuhiro Tsujikawa2023-09-171-3/+1
| |/ /
* | | Merge pull request #2103 from aria2/docker-mingw-update-libssh2-flagsTatsuhiro Tsujikawa2023-09-181-2/+0
|\ \ \ | | | | | | | | Dockerfile.mingw: Remove deprecated libssh2 configure flags
| * | | Dockerfile.mingw: Remove deprecated libssh2 configure flagsTatsuhiro Tsujikawa2023-09-171-2/+0
| |/ /
* | | Merge pull request #2102 from aria2/docker-android-add-dpkg-devTatsuhiro Tsujikawa2023-09-171-1/+1
|\ \ \ | |/ / |/| | Dockerfile.android: Add dpkg-dev for dpkg-architecture
| * | Dockerfile.android: Add dpkg-dev for dpkg-architectureTatsuhiro Tsujikawa2023-09-171-1/+1
| | |
* | | Merge pull request #2101 from aria2/docker-mingw-parallel-buildTatsuhiro Tsujikawa2023-09-171-7/+7
|\ \ \ | |/ / |/| | Dockerfile.mingw: Parallel build
| * | Dockerfile.mingw: Parallel buildTatsuhiro Tsujikawa2023-09-171-7/+7
|/ /
* | Merge pull request #2100 from aria2/release-with-dockerTatsuhiro Tsujikawa2023-09-175-41/+45
|\ \ | | | | | | Make releases with docker
| * | Make releases with dockerTatsuhiro Tsujikawa2023-09-175-41/+45
| | | | | | | | | | | | | | | | | | This is slightly different from the current procedure because now android and mingw binaries are built from source code fetched from the remote repository.
* | | Merge pull request #2099 from aria2/fix-overflowTatsuhiro Tsujikawa2023-09-161-1/+1
|\ \ \ | |/ / |/| | Fix overflow
| * | Fix overflowTatsuhiro Tsujikawa2023-09-161-1/+1
|/ /
* | Merge pull request #2098 from aria2/revert-ci-docker-mingwTatsuhiro Tsujikawa2023-09-161-24/+0
|\ \ | | | | | | Revert "ci: Build mingw image"
| * | Revert "ci: Build mingw image"Tatsuhiro Tsujikawa2023-09-161-24/+0
|/ / | | | | | | This reverts commit a02ceeb6460eb537d1e48555422b72a8bacde0e4.
* | Merge pull request #2097 from aria2/ci-docker-mingwTatsuhiro Tsujikawa2023-09-161-0/+24
|\ \ | | | | | | ci: Build mingw image
| * | ci: Build mingw imageTatsuhiro Tsujikawa2023-09-161-0/+24
| | |
* | | Merge pull request #2096 from aria2/ci-gnutlsTatsuhiro Tsujikawa2023-09-161-6/+22
|\ \ \ | |/ / |/| | ci: Build with gnutls
| * | ci: Build with gnutlsTatsuhiro Tsujikawa2023-09-161-6/+22
|/ /
* | Merge pull request #2095 from aria2/fix-undefinedTatsuhiro Tsujikawa2023-09-162-7/+13
|\ \ | | | | | | Fix test errors with ubsan
| * | Fix test errors with ubsanTatsuhiro Tsujikawa2023-09-162-7/+13
|/ /
* | Merge pull request #2094 from aria2/update-wslayTatsuhiro Tsujikawa2023-09-162-2/+2
|\ \ | | | | | | Update wslay
| * | Update wslayTatsuhiro Tsujikawa2023-09-162-2/+2
| | |
* | | Merge pull request #2093 from aria2/remove-deprecated-unary-binary-funTatsuhiro Tsujikawa2023-09-164-6/+4
|\ \ \ | |/ / |/| | Remove deprecated std::unary_function and std::binary_function
| * | Remove deprecated std::unary_function and std::binary_functionTatsuhiro Tsujikawa2023-09-164-6/+4
|/ /
* | Merge pull request #2092 from aria2/dockerfile-androidTatsuhiro Tsujikawa2023-09-162-0/+171
|\ \ | | | | | | Add Dockerfile.android
| * | Add Dockerfile.androidTatsuhiro Tsujikawa2023-09-162-0/+171
|/ /
* | Merge pull request #1822 from FH0/masterTatsuhiro Tsujikawa2023-09-161-11/+3
|\ \ | | | | | | android(ndk r23) has timegm
| * | android(ndk r23) has timegmFH02021-09-161-11/+3
| | |
* | | Merge pull request #2091 from aria2/crypto-lib-randTatsuhiro Tsujikawa2023-09-161-2/+22
|\ \ \ | | | | | | | | Prefer random number generator from crypto libraries
| * | | Prefer random number generator from crypto librariesTatsuhiro Tsujikawa2023-09-161-2/+22
|/ / /
* | | Merge pull request #2089 from aria2/update-dockerfile-mingwTatsuhiro Tsujikawa2023-09-162-33/+26
|\ \ \ | | | | | | | | Update Dockerfile.mingw
| * | | Update Dockerfile.mingwTatsuhiro Tsujikawa2023-09-152-33/+26
|/ / /
* | | Merge pull request #2088 from aria2/fix-libssh2-static-linkTatsuhiro Tsujikawa2023-09-151-0/+4
|\ \ \ | | | | | | | | Fix static link failure against libssh2
| * | | Fix static link failure against libssh2Tatsuhiro Tsujikawa2023-09-151-0/+4
|/ / /
* | | Merge pull request #1804 from nkh0472/patch-1Tatsuhiro Tsujikawa2023-09-151-72/+72
|\ \ \ | | | | | | | | Minor grammar improvements
| * | | Minor grammar improvementsnkh04722021-08-221-72/+72
| |/ / | | | | | | | | | Fix a typo 'Anroid' --> 'Android'; Minor grammar improvements.
* | | Merge pull request #1893 from kelson42/increase-bytearraydiskwriter-maxTatsuhiro Tsujikawa2023-09-151-1/+1
|\ \ \ | | | | | | | | Increase ByteArrayDiskWriter maximum size
generated by cgit (git 2.46.0) at 2026-10-12 00:55:24 +0000