diff options
| author | Nils Maier <maierman@web.de> | 2013-07-07 06:01:34 +0200 |
|---|---|---|
| committer | Nils Maier <maierman@web.de> | 2013-07-07 14:42:36 +0200 |
| commit | fc6318d23f58827427be8ccbdab1a82da2a1c9bf (patch) | |
| tree | cddc5f685b1c7e124556e9a24e8dfe2a2eccd410 /src/HttpConnection.cc | |
| parent | 3f5f1e26d9932a00caffb4866e8a277b7477fa47 (diff) | |
Fix a bad std::move in HttpConnection
C++ Standard says that the order of evaluation of arguments is
unspecified. Even if it wasn't, std::move would run first, invalidating
the httpRequest smartptr, so that httpRequest->createRequest() would be
executed on the invalid ptr.
Some compilers might be smart enough to correct this error, clang XCode
Edition surely is not (not should it).
Diffstat (limited to 'src/HttpConnection.cc')
| -rw-r--r-- | src/HttpConnection.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/HttpConnection.cc b/src/HttpConnection.cc index 596779d9..8574338e 100644 --- a/src/HttpConnection.cc +++ b/src/HttpConnection.cc @@ -123,7 +123,8 @@ void HttpConnection::sendRequest void HttpConnection::sendRequest (std::unique_ptr<HttpRequest> httpRequest) { - sendRequest(std::move(httpRequest), httpRequest->createRequest()); + auto req = httpRequest->createRequest(); + sendRequest(std::move(httpRequest), req); } void HttpConnection::sendProxyRequest |