diff options
| author | Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com> | 2010-02-28 16:04:52 +0000 |
|---|---|---|
| committer | Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com> | 2010-02-28 16:04:52 +0000 |
| commit | 72e475dfdeaa4a87dff0eef994e7814e94c40363 (patch) | |
| tree | 94a84e90c14876db223e4a733f651fe0b034f5e9 /src/DHTFindNodeReplyMessage.cc | |
| parent | c342bde9627b434effbc0cd10b817670d1da0923 (diff) | |
2010-03-01 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Avoid to calculate end() iterator in each loop. std::deque is
particularly slow. Make sure that recalculate end iterator if
element is erased during loop.
Diffstat (limited to 'src/DHTFindNodeReplyMessage.cc')
| -rw-r--r-- | src/DHTFindNodeReplyMessage.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/DHTFindNodeReplyMessage.cc b/src/DHTFindNodeReplyMessage.cc index 269b0a62..387024f7 100644 --- a/src/DHTFindNodeReplyMessage.cc +++ b/src/DHTFindNodeReplyMessage.cc @@ -61,8 +61,8 @@ DHTFindNodeReplyMessage::~DHTFindNodeReplyMessage() {} void DHTFindNodeReplyMessage::doReceivedAction() { - for(std::vector<SharedHandle<DHTNode> >::iterator i = _closestKNodes.begin(); - i != _closestKNodes.end(); ++i) { + for(std::vector<SharedHandle<DHTNode> >::iterator i = _closestKNodes.begin(), + eoi = _closestKNodes.end(); i != eoi; ++i) { if(memcmp((*i)->getID(), _localNode->getID(), DHT_ID_LENGTH) != 0) { _routingTable->addNode(*i); } @@ -77,8 +77,8 @@ BDE DHTFindNodeReplyMessage::getResponse() unsigned char buffer[DHTBucket::K*26]; // TODO if _closestKNodes.size() > DHTBucket::K ?? for(std::vector<SharedHandle<DHTNode> >::const_iterator i = - _closestKNodes.begin(); - i != _closestKNodes.end() && offset < DHTBucket::K*26; ++i) { + _closestKNodes.begin(), eoi = _closestKNodes.end(); + i != eoi && offset < DHTBucket::K*26; ++i) { SharedHandle<DHTNode> node = *i; memcpy(buffer+offset, node->getID(), DHT_ID_LENGTH); if(bittorrent::createcompact(buffer+20+offset, node->getIPAddress(), |